Skip to content

Conversation

@zyfy29
Copy link
Contributor

@zyfy29 zyfy29 commented Aug 13, 2025

Issue partiql/partiql-lang-kotlin#1734

Description of changes:

add eval test cases for string to datetime cast function, contains

  • date
  • time
  • time with time zone
  • timestamp
  • timestamp with time zone

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copilot AI review requested due to automatic review settings August 13, 2025 05:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds comprehensive test coverage for string to datetime cast functions including both valid and invalid casting scenarios for various datetime types.

  • Adds valid cast test cases for DATE, TIME, TIME WITH TIME ZONE, TIMESTAMP, and TIMESTAMP WITH TIME ZONE
  • Adds invalid cast test cases that attempt to cast datetime strings to INT type
  • Verifies proper behavior in both EvalModeCoerce and EvalModeError modes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant