Fix failing scala unit tests by providing unique app IDs in test #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthosa
force-pushed
the
spark-rapids-tools-1319-fix-UTs
branch
from
4d86a2f to
2fc2b3f
Compare
Signed-off-by: Partho Sarthi <[email protected]>
parthosa
changed the base branch from
spark-rapids-tools-1319
to
spark-rapids-tools-1319-b
parthosa
force-pushed
the
spark-rapids-tools-1319-fix-UTs
branch
from
2fc2b3f to
81b9594
Compare
Signed-off-by: Partho Sarthi <[email protected]>
parthosa
added a commit
that referenced
this pull request
Sep 3, 2024
* Adding synchronization on the reporting and autotuner level Signed-off-by: Ahmed Hussein (amahussein) <[email protected]> * Fix failing scala unit tests by providing unique app IDs in test (#53) * Fix UTs Signed-off-by: Partho Sarthi <[email protected]> * Ignore test for event logs with same app Id and attempt Id Signed-off-by: Partho Sarthi <[email protected]> --------- Signed-off-by: Partho Sarthi <[email protected]> --------- Signed-off-by: Ahmed Hussein (amahussein) <[email protected]> Signed-off-by: Partho Sarthi <[email protected]> Co-authored-by: Ahmed Hussein (amahussein) <[email protected]>
parthosa
added a commit
that referenced
this pull request
Sep 10, 2024
…ut in Scala Tool (NVIDIA#1324) * Add safeguards to prevent older attempts from generating qual summary output * Adding synchronization on the reporting and autotuner level (#54) * Fix failing scala unit tests by providing unique app IDs in test (#53) * Ignore test for event logs with same app Id and attempt Id --------- Signed-off-by: Partho Sarthi <[email protected]> Signed-off-by: Ahmed Hussein (amahussein) <[email protected]> Co-authored-by: Ahmed Hussein (amahussein) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the failing Scala Unit tests. This was mainly because we were processing multiple event logs with same App IDs.
Changes