Skip to content

node-forge used as phantom dependency in gcenter.js #10444

Description

@Stovedal

New Issue Checklist

Issue Description

When upgrading a different packaged that used to hoist node-forge we experienced a failure since node-forge is not declared in package.json but imported in gcenter.js. We solved it by hoisting it ourselves, but it should be installed as a dependency on parse-server.

Steps to reproduce

Install parse-server without having a hoisted node-forge installed.

Actual Outcome

Failure due to node-forge not being installed.

Expected Outcome

node-forge being installed automatically.

Environment

Server

  • Parse Server version: 8.6.72
  • Operating system: MacOS
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): local

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions