feat: added support for the IPFS hash type #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addressing issue#379 implementation test ------------------- cargo test -p resolc ipfs cargo test -p revive-solc-json-interface ipfs Signed-off-by: 0xf333 <[email protected]>
xermicus
requested changes
Nov 10, 2025
Member
xermicus
left a comment
xermicus
left a comment
There was a problem hiding this comment.
Hi, many thanks for the PR!
The end goal (to make this useful first hand) is to append it as CBOR data to the bytecode.
See also the solc documentation:
https://docs.soliditylang.org/en/latest/metadata.html#encoding-of-the-metadata-hash-in-the-bytecode
https://docs.soliditylang.org/en/latest/060-breaking-changes.html#metadata-hash-options
Sorry it doesn't say it in the issue. I added a few sentences to the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xermicus
this is to address issue #379
implementation test
cargo test -p resolc ipfscargo test -p revive-solc-json-interface ipfs