-
Notifications
You must be signed in to change notification settings - Fork 918
update Readme to obtain coretime on Paseo #8451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reads okay to me, have you tried the steps exactly as-is, and confirm that it works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this guide more or less what we have here: https://docs.polkadot.com/tutorials/polkadot-sdk/parachains/zero-to-hero/deploy-to-testnet/?
I am considering just mentioning the links:
- https://docs.polkadot.com/tutorials/polkadot-sdk/parachains/zero-to-hero/deploy-to-testnet/
- https://docs.polkadot.com/tutorials/polkadot-sdk/parachains/zero-to-hero/obtain-coretime/
Would this work?
1. To perform this step, you can use subkey, a command-line tool for generating and managing keys: | ||
``` | ||
docker run -it parity/subkey:latest generate --scheme sr25519 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is more or less that is in https://docs.polkadot.com/tutorials/polkadot-sdk/parachains/zero-to-hero/deploy-to-testnet/ however, this is a little more summarised, and adds up to this entire readme altogether, so that once somebody has created a parachain, they can get that dopamine to see its result to completion
|
||
### Start the Collator Node | ||
|
||
1. Before starting a collator, you need to generate a node key. This key is responsible for communicating with other nodes over Libp2p: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit (libp2p should be replaced in some places with litep2p, including on paseo)
1. Before starting a collator, you need to generate a node key. This key is responsible for communicating with other nodes over Libp2p: | |
1. Before starting a collator, you need to generate a node key. This key is responsible for communicating with peers as in a p2p network: |
@kianenigma I verified the original zero to hero tutorial, I will run this entire tutorial again, just to be sure, would also spot any other gaps and fix them, if any |
I tried it and it works, in case anybody wants to do a second round JIT, happy to wait for that. Additionally, I will just apply suggestions from @iulianbarbu and resolve conflicts before merging |
I see. Actually I don't have a strong opinion for removing the summary. What I would do more is maybe introduce the links to the zero-to-hero at the beginning of the LE: this suggestion is more for trying to dedup certain parts of our docs (which are mentioned in a few places), by referencing first and foremost a single place which is kept up to date with every release ideally, and to be first in the list of things people try. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd also need to add these new sections inside the ToC at the beginning of the file.
@@ -242,6 +242,127 @@ npx @acala-network/chopsticks@latest --chain-spec <path/to/chain_spec.json> | |||
support it at this moment. It can still be used to test a runtime in a full setup where it is started alongside a | |||
relay chain network (see [Parachain Template node](#parachain-template-node) setup). | |||
|
|||
#### Deploy to Paseo TestNet & See Your First Block |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have 2 #
instead of 4, and 3 for the rest of sub steps? This one feels like a header title.
Instructions for coretime purchase on paseo.