[AHM] Staking async fixes for XCM and election planning #8422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\cmd prdoc --bump minor |
acatangiu
reviewed
May 5, 2025
substrate/frame/staking-async/runtimes/parachain/src/staking.rs
Outdated
Show resolved
Hide resolved
substrate/frame/staking-async/runtimes/parachain/src/staking.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Adrian Catangiu <[email protected]>
Co-authored-by: Adrian Catangiu <[email protected]>
Co-authored-by: Adrian Catangiu <[email protected]>
acatangiu
approved these changes
May 5, 2025
…staking-async-xcm-weight
|
/cmd prdoc --bump minor |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings a few small fixes related to the XCM messages of stkaing-async, among other small fixes:
xcm::validateto check the message size, and we actually now act upon it in thestaking-async-rc/parachain-runtimes. The code is a bit duplicate now, and there is a TOOD about how to better refactor it later.EraElectionPlannerOfwhich should be the right tool to use to ensure elections always happen in time, with an educated guess based onElectionProvider::durationrather than a random number.INFO, and makes the printing of some types a bit more CLI friendly.type SessionDurationinstaking-asynctotype RelaySessionDurationfor better clarity.