Skip to content

Migrate pallet-nft-fractionalization to umbrella crate #7970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 11, 2025
Merged

Migrate pallet-nft-fractionalization to umbrella crate #7970

merged 12 commits into from
Apr 11, 2025

Conversation

kR1s0147
Copy link
Contributor

@kR1s0147 kR1s0147 commented Mar 19, 2025 •
edited
Loading

Part of #6504

@kR1s0147 kR1s0147 requested a review from a team as a code owner March 19, 2025 12:14
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Mar 19, 2025

User @kR1s0147, please sign the CLA here.

@kR1s0147 kR1s0147 marked this pull request as draft March 19, 2025 12:15
@kR1s0147 kR1s0147 marked this pull request as ready for review March 19, 2025 12:26
@re-gius re-gius mentioned this pull request Apr 2, 2025
Closed
48 tasks
re-gius
re-gius approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@re-gius re-gius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@re-gius re-gius added R0-silent The change does not warrant a re-release of the modified crates. T2-pallets This PR/Issue is related to a particular pallet. labels Apr 2, 2025
re-gius
re-gius reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@re-gius re-gius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes overall look good, but there are some extra spaces here and there to remove (see also CI errors or try to do cargo check locally)

re-gius
re-gius reviewed Apr 2, 2025
View reviewed changes
@github-actions github-actions bot requested a review from re-gius April 3, 2025 08:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Review required! Latest push from author must always be reviewed

re-gius
re-gius requested changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@re-gius re-gius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix failing CI, e.g.

https://github.com/paritytech/polkadot-sdk/actions/runs/14239250446/job/39909288801?pr=7970

@github-actions github-actions bot requested a review from re-gius April 3, 2025 11:05
@kR1s0147
Copy link
Contributor Author

kR1s0147 commented Apr 3, 2025

cargo fmt --check has ran successfully without any errors

bkchr
bkchr requested changes Apr 3, 2025
View reviewed changes
@kR1s0147 kR1s0147 force-pushed the migrate-nft-fractionalisation-to-umbrella branch 2 times, most recently from 20d4074 to 4f79ecb Compare April 5, 2025 09:31
@re-gius
Copy link
Contributor

re-gius commented Apr 8, 2025

Please run taplo format --config .config/taplo.toml to fix the toml formatting issues

@kR1s0147
Copy link
Contributor Author

kR1s0147 commented Apr 8, 2025

have committed the changes

@kR1s0147 kR1s0147 force-pushed the migrate-nft-fractionalisation-to-umbrella branch from b45fff2 to 8d31e2b Compare April 8, 2025 13:00
@re-gius
Copy link
Contributor

re-gius commented Apr 8, 2025

I think you just need to undo the changes to the Cargo.toml file outside the nft-fractionalization folder

@kR1s0147
Copy link
Contributor Author

kR1s0147 commented Apr 8, 2025

i have ran it on "polkadot-sdk/substrate/frame/nft-fractionalization" so it showed errors on taplo formatting errors and now i have ran it in polkadot-sdk/
and committed the changes

@paritytech-review-bot paritytech-review-bot bot requested a review from a team April 8, 2025 13:17
re-gius
re-gius approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@re-gius re-gius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kR1s0147 kR1s0147 requested a review from bkchr April 9, 2025 01:30
@bkchr bkchr enabled auto-merge April 11, 2025 21:08
@bkchr bkchr added this pull request to the merge queue Apr 11, 2025
Merged via the queue into paritytech:master with commit 6ce6110 Apr 11, 2025
233 of 243 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@re-gius re-gius re-gius approved these changes

Assignees
No one assigned
Labels
R0-silent The change does not warrant a re-release of the modified crates. T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kR1s0147 @re-gius @bkchr