Update subxt #864
Open
Update subxt #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiEres
force-pushed
the
AndreiEres/update-subxt
branch
from
a454e36 to
46e83d4
Compare
jsdw
reviewed
May 27, 2025
|
|
||
| let head = subxt.get_block_head(rpc_node_url(), None).await.unwrap().unwrap(); | ||
| let cores = subxt.get_occupied_cores(rpc_node_url(), head.hash()).await; | ||
| let cores = subxt.get_occupied_cores(rpc_node_url(), hasher.hash_of(&head)).await; |
There was a problem hiding this comment.
I wonder whether you can avoid needing to expose the hasher for many of these calls by doing one of the following:
- Have a function like
get_block_hashrather (or as well as)get_block_head. In Subxt, blocks have a.hash()method for instance that could return this. - Have functions accept a block header rather than a block hash (so that the hashing can be handled "internally" by Subxt). Perhaps this is difficult because it looks like you pass things through a channel, so would need owned values and headers are larger than hashes to have to be sending etc.
- Functions could also accept something like a
trait IntoBlockHash { fn hash() }type trait and then we have impls for hashes but also blocks or whatever. Maybe suffers from the same issue as 2 does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.