Implement log filters #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Cihodaru <[email protected]>
alindima
reviewed
Nov 20, 2025
| } | ||
| Poll::Ready(Some(Ok(new_blocks).to_rpc_result())) | ||
| } | ||
| // handled directly in get_filter_changes |
There was a problem hiding this comment.
IMO it'd be cleaner if we used the same pattern for all filter types. either implementing poll manually or using async functions for all
Author
There was a problem hiding this comment.
Will do this in the last PR of the filters series. I already have the change locally.
Signed-off-by: Alexandru Cihodaru <[email protected]>
alindima
approved these changes
Nov 20, 2025
iulianbarbu
approved these changes
Nov 21, 2025
Comment on lines
+197
to
+198
| // This can be optimized if we also submit the block number | ||
| // from subscribe_and_cache_new_blocks |
There was a problem hiding this comment.
Probably a similar block by hash will be done there as well to return the block number. I think the subscriptions return only hashes.
Signed-off-by: Alexandru Cihodaru <[email protected]>
Signed-off-by: Alexandru Cihodaru <[email protected]>
Signed-off-by: Alexandru Cihodaru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.