fix compiler version parsing #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .ok_or_else(|| SolcError::msg("Unable to retrieve version from resolc output")) | ||
| .and_then(|version| { | ||
| Version::from_str(version) |
There was a problem hiding this comment.
Should we still care about the logic to strip commit hashes (e.g. split('+').next() that was implemented before) to ensure Version::from_str receives a clean version string?
There was a problem hiding this comment.
it should be fine as we concatenate the build data if it's present
filip-parity
approved these changes
May 28, 2025
smiasojed
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates version parsing from
resolcstdout--versioncommand to account for v1.* releases