-
Notifications
You must be signed in to change notification settings - Fork 0
attempt to fix caching #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of nitpicks (feel free to skip them if you prefer) and a question.
also removed hashing of |
Could we please separate the PR for caching from the one for compiler version reporting? Caching is very important for us, whereas compiler reporting is not a priority. |
those two are intertwined in the PR |
I looks that it works, thanks |
Description
attempts to fix caching for
resolc
.This PR will also:
Reporter
, because we now print out that we depend onsolc
in version.build.e.g
[⠘] Compiling 24 files with Resolc 0.1.0-dev.15+Solc.0.8.29
see for explanations paritytech/foundry-polkadot#125.
Issues that still persist
forge build will recompile only once with the given new version and stop afterwards.
e.g.
The same issue is also encountered when using plain
solc
.