Skip to content

attempt to fix caching #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 23, 2025
Merged

attempt to fix caching #25

merged 11 commits into from
May 23, 2025

Conversation

pkhry
Copy link

@pkhry pkhry commented May 15, 2025

Description

attempts to fix caching for resolc.

This PR will also:

  • revert the logging code for the Reporter, because we now print out that we depend on solc in version.build.
    e.g [⠘] Compiling 24 files with Resolc 0.1.0-dev.15+Solc.0.8.29

see for explanations paritytech/foundry-polkadot#125.

Issues that still persist

forge build will recompile only once with the given new version and stop afterwards.
e.g.

$ forge build --resolc-compile --use_resolc=0.1.0-dev.13
[⠊] Compiling...
<compiled successfully>
$ forge build --resolc-compile --use_resolc=0.1.0-dev.16
[⠊] Compiling...
<compiled successfully>
$ forge build --resolc-compile --use_resolc=0.1.0-dev.13
[⠊] Compiling...
No files changed, compilation skipped

The same issue is also encountered when using plain solc.

@pkhry pkhry requested review from smiasojed and filip-parity May 15, 2025 16:00
@pkhry pkhry marked this pull request as ready for review May 15, 2025 16:01
Copy link

@filip-parity filip-parity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of nitpicks (feel free to skip them if you prefer) and a question.

@pkhry
Copy link
Author

pkhry commented May 16, 2025

LGTM, a couple of nitpicks (feel free to skip them if you prefer) and a question.

also removed hashing of output in buildInfo as it's no longer required.

@pkhry pkhry requested a review from filip-parity May 16, 2025 08:16
@pkhry pkhry requested a review from smiasojed May 19, 2025 16:31
@pkhry pkhry requested a review from smiasojed May 20, 2025 09:22
@smiasojed
Copy link
Collaborator

Could we please separate the PR for caching from the one for compiler version reporting? Caching is very important for us, whereas compiler reporting is not a priority.

@pkhry
Copy link
Author

pkhry commented May 21, 2025

Could we please separate the PR for caching from the one for compiler version reporting? Caching is very important for us, whereas compiler reporting is not a priority.

those two are intertwined in the PR

@smiasojed
Copy link
Collaborator

I looks that it works, thanks

@pkhry pkhry merged commit 06ac06e into main May 23, 2025
16 checks passed
@pkhry pkhry deleted the pkhry/attempt_to_fix_caching branch May 23, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants