This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Validate timestamps against relay chain slot #437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
suggested changes
May 13, 2021
| /// This data is also absent from the genesis. | ||
| #[pallet::storage] | ||
| #[pallet::getter(fn relay_slot)] | ||
| pub(super) type RelaySlot<T: Config> = StorageValue<_, Slot>; |
There was a problem hiding this comment.
I don't see any reason to add this here as a storage item.
| //! Utility module to validate cumulus-runtime timestamps against the | ||
| //! relay chain slot. | ||
|
|
||
| use cumulus_primitives_core::{OnValidationData, Slot}; |
There was a problem hiding this comment.
This should be its own pallet. Similar to aura-ext. Maybe timestamp-ext or something.
The idea with using environmental was also a bad idea by me. We should probably store the intermediate data in the storage.
|
Superseded by #494 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #422.
Depends on paritytech/polkadot#3022.