-
Notifications
You must be signed in to change notification settings - Fork 79
Build and test in a matrix #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b3132ab
to
a8b6b8b
Compare
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
To catch the #282, we would need to also run the tests on this target. |
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
a8b6b8b
to
e0c4cfc
Compare
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
In this case, to be precise we don't actually need to run tests we just need to compile them. I think we don't need to strictly I've updated the matrix job and it's clearly visible it's not just that particular 32bit target that was failing. To be honest I'd move the |
Fixes: parallaxsecond#282 Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
I've cherry-picked your commits from the other PR... let's see how many tests will be green now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like all of them were fixed :)
I like the idea of running on the whole matrix. It makes it easier to catch all possible oddness (but really the most common one is the ulong size which demonstrates on 32b arches). The linux-x86_64 is missing though.
On the other hand, I would probably be interested in running the test on 32b arch too (can be separate PR based on what I did in #283). We can probably do it easily only on i386 though. We might get the arm64 runner as mentioned in #285 and we might be able to run there the arm32 binaries, but I never played around this and I an skeptical it will show other errors than the i386 ones.
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Okay, I've simplified it further: noticed that we're checking formatting twice (once in a job, second time in See if this looks any better and thanks for review! 👋 Btw, we won't be able to merge this anyway until @hug-dev changes the definition of "Required" checks (they're hardcoded for now to look for old jobs). |
No description provided.