Modify socket path to conform to FHS #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unix domain sockets should be in /run/. Signed-off-by: Hugues de Valon <[email protected]>
|
Do we need to modify and upstream the client first? |
|
Yes probably, for the CI to pass. I have created a PR on the client here. I also realised I forgot pushing updates to the systemd unit file, I am doing that now. |
hug-dev
commented
Sep 23, 2020
hug-dev
force-pushed
the
new-socket-path
branch
2 times, most recently
from
ccd293e to
d8927d4
Compare
Signed-off-by: Hugues de Valon <[email protected]>
hug-dev
force-pushed
the
new-socket-path
branch
from
d8927d4 to
3e41670
Compare
ionut-arm
approved these changes
Sep 28, 2020
| @@ -17,6 +17,7 @@ | |||
|
|
|||
| # Log level to be applied across the service. Can be overwritten for certain modules which have the same | |||
| # configuration key. Possible values: "debug", "info", "warn", "error", "trace" | |||
| # WARNING: This option will not be updated if the configuration is reloaded with a different one. | |||
|
|
||
| let listener = UnixListener::bind(SOCKET_PATH)?; | ||
| // Will fail if a file already exists at the path. |
There was a problem hiding this comment.
Then why don't we just panic instead of error on line 54?
There was a problem hiding this comment.
I think this is in the same line of ideas of trying to avoid as many panic as possible 😃
There was a problem hiding this comment.
True, I guess we can let it wind down, though I wouldn't mind panics for the issues with which the service cannot continue worrking
Signed-off-by: Hugues de Valon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unix domain sockets should be in /run/.
See #250 for reference.