Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add discv4 terminate #4888

Closed
wants to merge 5 commits into from
Closed

feat: add discv4 terminate #4888

wants to merge 5 commits into from

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 3, 2023

Closes #4874

supersedes #4879

@mattsse mattsse requested a review from Rjected as a code owner October 3, 2023 10:46
@mattsse mattsse added C-enhancement New feature or request A-networking Related to networking in general labels Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #4888 (00aec1a) into main (fbfca3f) will increase coverage by 0.03%.
Report is 3 commits behind head on main.
The diff coverage is 18.18%.

Impacted file tree graph

Files Coverage Δ
crates/net/discv4/src/lib.rs 64.41% <18.18%> (-0.37%) ⬇️

... and 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.54% <9.09%> (+0.03%) ⬆️
unit-tests 62.58% <18.18%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.63% <ø> (+0.35%) ⬆️
blockchain tree 80.44% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 73.32% <ø> (+0.02%) ⬆️
trie 94.48% <ø> (-0.04%) ⬇️
txpool 49.63% <ø> (+0.50%) ⬆️
networking 76.10% <18.18%> (-0.06%) ⬇️
rpc 57.72% <ø> (-0.06%) ⬇️
consensus 61.06% <ø> (ø)
revm 28.54% <ø> (ø)
payload builder 8.16% <ø> (ø)
primitives 85.24% <ø> (-0.02%) ⬇️

@mattsse mattsse closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Discv4Command variant to terminate the service
2 participants