fix(trie): check branch node masks if store_in_db_trie
is None
#13828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning
false
is not correct herereth/crates/trie/sparse/src/trie.rs
Lines 1212 to 1219 in 7e972ea
Imagine we have the following situation:
On a call to
rlp_node
, the extension node will have itsstore_in_db_trie
set tofalse
because its child node is aHash
node that returnedfalse
on a call tostore_in_db_trie()
. This will result in incorrect tree mask for the root branch node.This PR fixes the trie updates mismatch on Mainnet block 21638721.