Skip to content

Specify that SHELL is bash, since bashisms ([[ COND ]]) are used #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

Specify that SHELL is bash, since bashisms ([[ COND ]]) are used #1073

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5fc6de
Specify that SHELL is bash, since bashisms (`[[ COND ]]`) are used
yarikoptic Sep 22, 2025
9238b11
Add trailing ";" to bash multiline constructs in "uninstall" of Makefile
yarikoptic Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ else
GNOME_EXT_DISABLE := gnome-shell-extension-tool --disable
endif

SHELL=/bin/bash

## Update compiled files
all: $(RELEASE_FILES)

Expand Down Expand Up @@ -68,7 +70,7 @@ uninstall:
@if [[ `readlink -f $(TARGET)` != `readlink -f $$PWD` ]]; \
then \
echo "'$(TARGET)' does not link to '$$PWD', refusing to remove."; \
exit 1 \
exit 1; \
fi
@if [ -L $(TARGET) ]; \
then \
Expand All @@ -77,7 +79,7 @@ uninstall:
else \
read -p "Remove $(TARGET)? (y/N): " -n 1 -r \
echo \
[[ $$REPLY =~ ^[Yy]$ ]] && rm -rf $(TARGET) \
[[ $$REPLY =~ ^[Yy]$ ]] && rm -rf $(TARGET); \
fi


Expand Down