Skip to content

Conversation

@Thesola10
Copy link
Collaborator

This is a tentative change which removes a few of the shell scripts at the repo root, by merging them into a single Makefile.

Feedback is welcome!

@Thesola10 Thesola10 added the project support Issues related to supporting or improving the project label Mar 27, 2025
@github-actions
Copy link

Thanks for your contribution! We don't accept pull requests to the release branch. I have rebased your pull request onto develop, check for any conflicts.

@github-actions github-actions bot changed the base branch from release to develop March 27, 2025 19:22
@jtaala jtaala marked this pull request as ready for review March 29, 2025 23:07
@jtaala jtaala self-requested a review March 29, 2025 23:09
jtaala
jtaala previously requested changes Mar 29, 2025
Copy link
Collaborator

@jtaala jtaala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would just need a quick update to the README.md and will be good to go.

I've update the README.md.

Nice work @Thesola10!

@jtaala jtaala self-requested a review March 29, 2025 23:18
Copy link
Collaborator

@jtaala jtaala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functions.

Install and generating zip works well!

Uninstall did work, but I did get an error there:

[jay@m16 pwm]$ make uninstall
GNOME_EXT_DISABLE	 [email protected]
/bin/sh: -c: line 6: syntax error: unexpected end of file
make: *** [Makefile:68: uninstall] Error 2

@jtaala jtaala dismissed their stale review March 29, 2025 23:21

I updated README.md.

@Thesola10 Thesola10 requested a review from jtaala August 10, 2025 17:28
@Thesola10 Thesola10 merged commit 09dc10e into develop Aug 11, 2025
@Thesola10 Thesola10 deleted the makefile branch August 11, 2025 13:07
@smichel17
Copy link
Member

Personally I like:

  • Make a scripts folder for all the scripts
  • Add a Makefile with a bunch of .PHONY targets to invoke the scripts
    • (Once it's packaged in enough distros, I'll probably move from make to just for this)

That way,

  • The scripts don't clutter the root folder.
  • People without make installed can still invoke the scripts easily / we don't need to install make in CI.
  • People who use make get tab autocompletion.
  • We get the social value of using a widespread tool. e.g. when a newcomer sees a Makefile, they probably know they can look in there and it'll kinda double as build documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project support Issues related to supporting or improving the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants