-
Notifications
You must be signed in to change notification settings - Fork 150
Merging utility scripts into a root Makefile #1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your contribution! We don't accept pull requests to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Would just need a quick update to the README.md and will be good to go.
I've update the README.md.
Nice work @Thesola10!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested functions.
Install and generating zip works well!
Uninstall did work, but I did get an error there:
[jay@m16 pwm]$ make uninstall
GNOME_EXT_DISABLE [email protected]
/bin/sh: -c: line 6: syntax error: unexpected end of file
make: *** [Makefile:68: uninstall] Error 2
|
Personally I like:
That way,
|
This is a tentative change which removes a few of the shell scripts at the repo root, by merging them into a single Makefile.
Feedback is welcome!