Changed touch detection for Workspace button #1010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! We don't accept pull requests to the |
|
Thank you very much for being so patient. I recently updated the SSD of my tablet and is now reinstalling the system. It would take some time before I could test this. As for the change, I hope that we could eventually find a solution that uses the up-event instead of the down-event for short tapping buttons in the long run. A button triggered by the up-event allows aborting by dragging the touch pointer away from the button before lifting, and is therefore more fault-tolerant and more accessible to users with physical disability (ref. WCAG 2.1 2.5.2 Pointer Cancellation). |
ShamrockLee
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #992 by triggering the button action at the start of the touch event, rather than at the end.
@ShamrockLee please test