Skip to content

GNOME 48 support #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 29, 2025
Merged

GNOME 48 support #1003

merged 6 commits into from
Mar 29, 2025

Conversation

@Thesola10
Copy link
Collaborator

@Thesola10 Thesola10 commented Mar 7, 2025

This fixes #1002 by restoring PaperWM functionality on the latest GNOME 48.

Contributions are welcome!

@github-actions
Copy link

github-actions bot commented Mar 7, 2025

Thanks for your contribution! We don't accept pull requests to the release branch. I have rebased your pull request onto develop, check for any conflicts.

@github-actions github-actions bot changed the base branch from release to develop March 7, 2025 10:46
@Thesola10 Thesola10 added the gnome-48 Specific to GNOME Shell 48 label Mar 7, 2025
@mehiel
Copy link

mehiel commented Mar 14, 2025

Tried this branch after setting metadata.json to support 48 version but unfortunately when I activate the extension breaks gnome which exists the current sessions and goes back to gdm to login.

@Plyply99

This comment was marked as duplicate.

Sign in to view
@Thesola10
Copy link
Collaborator Author

Thesola10 commented Mar 16, 2025

There are no changes yet, just a setup for GNOME 48 testing, hence the "contributions are welcome".
Also yeah I forgot to bump metadata.json

@amfern
Copy link

amfern commented Mar 22, 2025

I get a crash when trying to use this branch.
journal-paperwm.log

@amfern
Copy link

amfern commented Mar 22, 2025

96ae4ebf-5028-4dce-a82c-bd076da20b03.log
gdb back trace

@Thesola10 Thesola10 force-pushed the gnome-48 branch 5 times, most recently from 59cb1fc to e362463 Compare March 24, 2025 10:06
@azmeuk
Copy link

azmeuk commented Mar 27, 2025

No crash for me, but navigation shortcuts are broken.

@Thesola10 Thesola10 force-pushed the gnome-48 branch 2 times, most recently from a6e1330 to c0147ea Compare March 27, 2025 11:56
@Thesola10
Updated test VM to reduce build time
bd88119 
This change also removes GNOME Circle apps from the test VM.
@Thesola10 Thesola10 mentioned this pull request Mar 27, 2025
Closed
@schrieveslaach

This comment was marked as duplicate.

Sign in to view
@Thesola10 Thesola10 marked this pull request as ready for review March 27, 2025 15:50
@Thesola10
Copy link
Collaborator Author

Thesola10 commented Mar 27, 2025

@schrieveslaach @azmeuk just pushed a fix for navigation keybinds

@Thesola10 Thesola10 requested a review from jtaala March 27, 2025 15:51
@azmeuk
Copy link

azmeuk commented Mar 27, 2025

@schrieveslaach @azmeuk just pushed a fix for navigation keybinds

I confirm this fixes the issues for me.

@fermuch
Copy link

fermuch commented Mar 27, 2025

@schrieveslaach @azmeuk just pushed a fix for navigation keybinds

I can confirm it is working for me too. Thanks!

Thesola10
Thesola10 commented Mar 27, 2025
View reviewed changes
@Thesola10 Thesola10 requested review from Lythenas and smichel17 March 27, 2025 16:02
@thenameisluk
Copy link

thenameisluk commented Mar 27, 2025

just wanted to let you know
that dragging window using titlebar
is instantly crashing shell

Distribution: Debian GNU/Linux
GNOME Shell: 48.0
Display server: Wayland
PaperWM version: 48.0.0
Enabled extensions:
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]

(on this branch)

@Thesola10

This comment was marked as outdated.

Sign in to view
@schrieveslaach
Copy link
Contributor

schrieveslaach commented Mar 27, 2025

@schrieveslaach @azmeuk just pushed a fix for navigation keybinds

Super + . and other keybindings work again.

@thenameisluk
Copy link

thenameisluk commented Mar 27, 2025

this only postponed the crash
it will work if you just grab it
but moving it down will again result in a crash

@data-flux
Copy link

data-flux commented Mar 27, 2025

Fedora Silverblue 42 beta, gnome version 48rc

  • Keyboard navigation works perfectly!
  • moving tiled windows with the mouse still crashes.

@Thesola10
Copy link
Collaborator Author

Thesola10 commented Mar 28, 2025 •
edited
Loading

Nevermind, found it: for some reason Meta.Cursor.MOVE_OR_RESIZE_WINDOW is undefined on GNOME 48, and of course Clutter responds by imploding on the spot.

Sure, GNOME, why don't you rename the cursors without a release note, and not bother handling the old names. Gotta love Javascript.

@Thesola10
Added exceptions for new cursor names in GNOME 48
483e782 
Of course this wasn't mentioned in any release notes, and they just HAD
to throw away the old names. Combined with JS going "lol undefined" and
Clutter happily eating it and crashing, it's the perfect storm.
@thenameisluk
Copy link

thenameisluk commented Mar 28, 2025

this fixed the crash
thx

jtaala
jtaala approved these changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@jtaala jtaala left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Thesola10!

Now running this - working well. Happy for this to be merged when you're ready.

@jtaala
Copy link
Collaborator

jtaala commented Mar 29, 2025

@Thesola10, let me know if you're waiting on anything, otherwise I can merge and create a new release (on EGO as well).

Jay.

@Thesola10
Copy link
Collaborator Author

Thesola10 commented Mar 29, 2025

No, please go ahead, had other things to do today and forgot

@Thesola10 Thesola10 merged commit 105663b into develop Mar 29, 2025
@jtaala
Copy link
Collaborator

jtaala commented Mar 29, 2025

No, please go ahead, had other things to do today and forgot

No problems!

@paradajz paradajz mentioned this pull request Mar 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtaala jtaala jtaala approved these changes

@smichel17 smichel17 Awaiting requested review from smichel17

@Lythenas Lythenas Awaiting requested review from Lythenas

Assignees

No one assigned

Labels

gnome-48 Specific to GNOME Shell 48

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GNOME 48 support