🧹 chore: Use daggerverse linear checker#32
Conversation
Signed-off-by: John McBride <john@papercompute.com>
|
| Filename | Overview |
|---|---|
| .github/workflows/pr.yaml | New GitHub Actions workflow adding two Dagger-backed PR checks (title conformance and Linear magic word). Module reference is unpinned; checkout steps appear unnecessary. |
Sequence Diagram
sequenceDiagram
participant GH as GitHub Actions
participant D as Dagger Engine
participant DV as daggerverse/ghcontrib
participant API as GitHub API
GH->>D: Install Dagger v0.20.6
GH->>D: dagger call check-pull-request --number {PR#}
D->>DV: Load module (unpinned HEAD)
DV->>API: GET /repos/{repo}/pulls/{PR#}
API-->>DV: PR title + body
DV-->>GH: Pass / Fail (title check)
GH->>D: dagger call check-pull-request-linear-magic-word --number {PR#}
D->>DV: Load module (unpinned HEAD)
DV->>API: GET /repos/{repo}/pulls/{PR#}
API-->>DV: PR body
DV-->>GH: Pass / Fail (Linear magic word check)
Comments Outside Diff (2)
-
.github/workflows/pr.yaml, line 32-38 (link)Unpinned Dagger module version
github.com/papercomputeco/daggerverse/ghcontribhas no version tag or commit SHA appended, so Dagger resolves it to the latest HEAD of that path on every run. Any breaking change to the module's interface (renamed command, changed flags, removed function) will silently break CI without any change to this workflow file. The same applies to the equivalent call incheck-linear-magic-word. Pin both calls to a specific tag or commit (e.g.github.com/papercomputeco/daggerverse/ghcontrib@<commit>) to get reproducible runs.Prompt To Fix With AI
This is a comment left during a code review. Path: .github/workflows/pr.yaml Line: 32-38 Comment: **Unpinned Dagger module version** `github.com/papercomputeco/daggerverse/ghcontrib` has no version tag or commit SHA appended, so Dagger resolves it to the latest HEAD of that path on every run. Any breaking change to the module's interface (renamed command, changed flags, removed function) will silently break CI without any change to this workflow file. The same applies to the equivalent call in `check-linear-magic-word`. Pin both calls to a specific tag or commit (e.g. `github.com/papercomputeco/daggerverse/ghcontrib@<commit>`) to get reproducible runs. How can I resolve this? If you propose a fix, please make it concise.
-
.github/workflows/pr.yaml, line 25-26 (link)Both jobs invoke the Dagger module exclusively via the GitHub API (
--token+--repo+ PR--number) and never read files from the local workspace. Theactions/checkout@v4step clones the repository for no reason, adding ~5-10 s to each job. The same pattern is repeated in thecheck-linear-magic-wordjob. Consider removing both checkout steps.Prompt To Fix With AI
This is a comment left during a code review. Path: .github/workflows/pr.yaml Line: 25-26 Comment: **Unnecessary checkout step** Both jobs invoke the Dagger module exclusively via the GitHub API (`--token` + `--repo` + PR `--number`) and never read files from the local workspace. The `actions/checkout@v4` step clones the repository for no reason, adding ~5-10 s to each job. The same pattern is repeated in the `check-linear-magic-word` job. Consider removing both checkout steps. How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
.github/workflows/pr.yaml:32-38
**Unpinned Dagger module version**
`github.com/papercomputeco/daggerverse/ghcontrib` has no version tag or commit SHA appended, so Dagger resolves it to the latest HEAD of that path on every run. Any breaking change to the module's interface (renamed command, changed flags, removed function) will silently break CI without any change to this workflow file. The same applies to the equivalent call in `check-linear-magic-word`. Pin both calls to a specific tag or commit (e.g. `github.com/papercomputeco/daggerverse/ghcontrib@<commit>`) to get reproducible runs.
### Issue 2 of 2
.github/workflows/pr.yaml:25-26
**Unnecessary checkout step**
Both jobs invoke the Dagger module exclusively via the GitHub API (`--token` + `--repo` + PR `--number`) and never read files from the local workspace. The `actions/checkout@v4` step clones the repository for no reason, adding ~5-10 s to each job. The same pattern is repeated in the `check-linear-magic-word` job. Consider removing both checkout steps.
Reviews (1): Last reviewed commit: "🧹 chore: Use daggerverse linear checker" | Re-trigger Greptile
Adds:
Towards CTO-33