fix

paologallinaharbur · Oct 2, 2020 · b24635e · b24635e
1 parent 6899a05
commit b24635e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 11 deletions.
diff --git a/.github/workflows/create_release.yml b/.github/workflows/create_release.yml
@@ -22,7 +22,6 @@
 ###                                                             |___________________________|
 
 on: 
-#pull_request
   push:
     branches:
       - master
@@ -40,24 +39,21 @@ jobs:
     name: Create Release
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/setup-go@v2
-        with:
-          go-version: '^1.13.1' 
       - name: Checkout code
         uses: actions/checkout@v2
       - name: Install dependencies
         run: |
           sudo wget -O /usr/local/bin/yq https://github.com/mikefarah/yq/releases/download/3.3.0/yq_linux_amd64
           sudo chmod +x /usr/local/bin/yq
-      - name: Check exporters have been modified
+      - name: Check if exporters have been modified
         id: check
         run : |
           git fetch -at origin --unshallow
           source ./scripts/common_functions.sh
           getExporterPath
           loadVariables
           setStepOutput
-      - name: Create Release
+      - name: Create Release for the exporter modified
         id: create_release
         if: ${{ steps.check.outputs.CREATE_RELEASE == 'true'}}
         uses: actions/create-release@v1
@@ -176,11 +172,10 @@ jobs:
           source ./scripts/common_functions.sh
           loadVariables
           setStepOutput
-      - name : CreateMSI
+      - name : Create MSI installer
         shell: pwsh
         run: |
           .\exporters\${{ steps.load_variables.outputs.NAME }}\win_build.ps1 -arch ${{ matrix.goarch }} -exporterHead ${{ steps.load_variables.outputs.EXPORTER_HEAD }} -exporterName ${{ steps.load_variables.outputs.NAME }} -exporterURL ${{ steps.load_variables.outputs.EXPORTER_REPO_URL }} -version ${{ steps.load_variables.outputs.VERSION }} -exporterGUID ${{ steps.load_variables.outputs.EXPORTER_GUID }} -licenseGUID ${{ steps.load_variables.outputs.LICENSE_GUID }}  -pfx_passphrase "$env:PFX_PASSPHRASE" 
-        # -pfx_certificate_base64 "$env:PFX_CERTIFICATE_BASE64" -pfx_passphrase "$env:PFX_PASSPHRASE"
       - name: Upload Release Asset MSI
         uses: actions/upload-release-asset@v1
         env:

diff --git a/exporters/githubactions/exporter.yml b/exporters/githubactions/exporter.yml
@@ -1,10 +1,20 @@
+# name of the exporter, should mach with the folder name
 name: githubactions
-version: 1.2.3
+# version of the package created
+version: 1.2.0
+# URL to the git project hosting the exporter
 exporter_repo_url: https://github.com/Spendesk/github-actions-exporter
+# Tag of the exporter to checkout
 exporter_tag: v1.2
-exporter_commit: ifTagIsSetThisIsNotUsed
-exporter_changelog: "Changelog for the current version, nothing relly changed, just testing pipeline"
+# Commit of the exporter to checkout (used if tag property is empty)
+exporter_commit: 
+# Changelog to add to the new release
+exporter_changelog: https://github.com/Spendesk/github-actions-exporter/releases
+# Enable packages for Linux
 package_linux: true
+# Enable packages for Windows
 package_windows: true
+# Exporter GUID used in the msi package Requiered if package_windows is set to true
 exporter_guid: 7B629E90-530F-4FAA-B7FE-1F1B30A95714
+# Lincense GUID used in the msi package Requiered if package_windows is set to true
 license_guid: 95E897AC-895A-43BE-A5EF-D72AD58E4ED1