TST: assert reading of legacy pickles against current data #61792
+59
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Testing
Comment on lines
+222
to
+229
| # "cat_onecol": DataFrame({"A": Categorical(["foo", "bar"])}), | ||
| "cat_onecol": DataFrame( | ||
| { | ||
| "A": Categorical.from_codes( | ||
| [1, 0], categories=Index(["bar", "foo"], dtype="object") | ||
| ) | ||
| } | ||
| ), |
There was a problem hiding this comment.
@jorisvandenbossche to get the old behavior here, the code changes are a bit more involved. I've not got round to reviewing all the migration guides/release notes yet. Is this included? if not, should it be?
| and legacy_version < Version("1.3.0") | ||
| ): | ||
| # convert to wall time | ||
| # (bug since pandas 2.0 that tz gets dropped for older pickle files) |
There was a problem hiding this comment.
is there an issue ref for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #61770, I noticed that we didn't actually compare the read pickle data to some ground truth expected value, but just to itself (we were essentially doing
assert_equal(result, result)..), due to some accidental change in a clean-up many years ago in f2246cf)Fixing that here by again creating the expected unpickled data with
create_pickle_data()during the test run, to compare with the data from the older pickled files.