BUG: Add PyArrow datelike type support for map()
#61644
Open
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevsterAmp
changed the title
map()map()
simonjayhawkins
added
Bug
Apply
|
Can you add tests based on the original issue |
pandas/core/arrays/arrow/array.py
Outdated
| or pa.types.is_date(self.dtype.pyarrow_dtype) | ||
| or pa.types.is_timestamp(self.dtype.pyarrow_dtype) | ||
| ] | ||
| ): |
There was a problem hiding this comment.
any idea why the super().map method isn't working correctly? If fixing things there is viable, that would be a better outcome
|
Looks like some tests are failing in the CI. Can you address those? |
|
@jbrockmendel sorry I was inactive last 2 weeks. Will take a look at this issue atm |
|
I now used I saw that the test function ( |
|
@jbrockmendel Is the fix for the existing test_map enough? or should I add a test similar to the issue as well? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.