Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Whatsnew for sorting mode result #60718

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Entry from #60702

@rhshadrach rhshadrach added this to the 2.3 milestone Jan 14, 2025
Comment on lines 2671 to 2673
# @pytest.mark.xfail(
# using_string_dtype(), reason="TODO(infer_string) None is cast to NaN"
# )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed instead of put in comments?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must of had the wrong branch checked out when making this. Will cleanup. This should just have the whatsnew note.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready now.

@rhshadrach rhshadrach marked this pull request as draft January 14, 2025 12:11
@rhshadrach rhshadrach marked this pull request as ready for review January 22, 2025 01:38
@mroeschke mroeschke merged commit c168c06 into pandas-dev:main Jan 22, 2025
19 of 20 checks passed
@mroeschke
Copy link
Member

Thanks @rhshadrach

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 22, 2025
mroeschke pushed a commit that referenced this pull request Jan 22, 2025
…sult) (#60760)

Backport PR #60718: DOC: Whatsnew for sorting mode result

Co-authored-by: Richard Shadrach <[email protected]>
asharmalik19 pushed a commit to asharmalik19/pandas that referenced this pull request Jan 22, 2025
* DOC: Whatsnew for sorting mode result

* Reverts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants