Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST(str dtype): Resolve xfail in test_value_counts.py #60701

Merged
merged 2 commits into from
Jan 12, 2025
Merged

TST(str dtype): Resolve xfail in test_value_counts.py #60701

merged 2 commits into from
Jan 12, 2025

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@rhshadrach rhshadrach added Testing pandas testing functions or related to the test suite Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Strings String extension data type and string data labels Jan 12, 2025
@rhshadrach rhshadrach added this to the 2.3 milestone Jan 12, 2025
@mroeschke mroeschke merged commit 5dee212 into pandas-dev:main Jan 12, 2025
51 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 12, 2025
@rhshadrach @meeseeksmachine
Backport PR pandas-dev#60701: TST(str dtype): Resolve xfail in test_v…
6b5b548 
…alue_counts.py
@mroeschke
Copy link
Member

Thanks @rhshadrach

@meeseeksmachine meeseeksmachine mentioned this pull request Jan 12, 2025
Merged
@rhshadrach rhshadrach deleted the str_xfail_value_counts branch January 12, 2025 21:17
mroeschke pushed a commit that referenced this pull request Jan 12, 2025
@meeseeksmachine @rhshadrach
Backport PR #60701 on branch 2.3.x (TST(str dtype): Resolve xfail in …
07c6cad 
…test_value_counts.py) (#60707)

Backport PR #60701: TST(str dtype): Resolve xfail in test_value_counts.py

Co-authored-by: Richard Shadrach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Strings String extension data type and string data Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@rhshadrach @mroeschke