Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix some core.resample.Resampler docstrings #60502

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

knowltod
Copy link
Contributor

@knowltod knowltod commented Dec 6, 2024

Similar to issues #59698, #59592, and #59458.

Fixes:

-i "pandas.core.resample.Resampler.max PR01,RT03,SA01" \
-i "pandas.core.resample.Resampler.mean SA01" \
-i "pandas.core.resample.Resampler.min PR01,RT03,SA01" \
-i "pandas.core.resample.Resampler.prod SA01" \
-i "pandas.core.resample.Resampler.std SA01" \
-i "pandas.core.resample.Resampler.var SA01" \

All docstrings are now only showing ES01 as missing, which according to code_checks.sh line 71, is okay.

@knowltod knowltod requested a review from mroeschke as a code owner December 6, 2024 00:13
@knowltod
Copy link
Contributor Author

knowltod commented Dec 8, 2024

pre-commit.ci autofix

@knowltod knowltod force-pushed the fix-docstring-resample branch from c1886cd to 5a4535e Compare December 8, 2024 18:23
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach
Copy link
Member

@knowltod - can you merge main and resolve the conflict

@rhshadrach rhshadrach added Docs Resample resample method labels Dec 30, 2024
@rhshadrach rhshadrach added this to the 3.0 milestone Dec 30, 2024
@mroeschke mroeschke merged commit b74ee4a into pandas-dev:main Jan 2, 2025
51 checks passed
@mroeschke
Copy link
Member

Thanks @knowltod

gmcrocetti pushed a commit to gmcrocetti/pandas that referenced this pull request Jan 3, 2025
* fixed resample.Resampler docstring errors in min, max, mean, prod, std, var as indicated by vaildate_docstrings.py

* fixed resample.Resampler docstring errors in min, max, mean, prod, std, var as indicated by vaildate_docstrings.py

* fixed trailing whitespace on line 1161

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Resample resample method
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants