BUG: Copy attrs on pd.merge() #60357
Open
+47
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
force-pushed
the
fix-merge-attrs
branch
from
a9725ef to
1d4c974
Compare
3 tasks
timhoffm
force-pushed
the
fix-merge-attrs
branch
from
1d4c974 to
8bd828c
Compare
timhoffm
force-pushed
the
fix-merge-attrs
branch
2 times, most recently
from
1e8c04b to
6697172
Compare
This uses the same logic as `pd.concat()`: Copy `attrs` only if all input `attrs` are identical. I've refactored the handling in __finalize__ from special-casing based on th the method name (previously only "concat") to handling "other" parameters that have an `input_objs` attribute. This is a more scalable architecture compared to hard-coding method names in __finalize__. Tests added for `concat()` and `merge()`. Closes pandas-dev#60351.
timhoffm
force-pushed
the
fix-merge-attrs
branch
from
6697172 to
7815e73
Compare
timhoffm
commented
Nov 19, 2024
Comment on lines
+1110
to
+1113
| result = result.__finalize__( | ||
| types.SimpleNamespace(input_objs=[self.left, self.right]), | ||
| method=self._merge_type, | ||
| ) |
There was a problem hiding this comment.
Note: I don't really understand why __finalize__ is called twice on the result, once here with method=self._merge_type and once below with method="merge". That looks dubious. If the duplication is needed, we should add a comment.
3 tasks
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
I'm still interested in this, and IMHO it's ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the same logic as
pd.concat(): Copyattrsonly if all inputattrsare identical.I've refactored the handling in finalize from special-casing based on th the method name (previously only "concat") to handling "other" parameters that have an
input_objsattribute. This is a more scalable architecture compared to hard-coding method names in finalize.Tests added for
concat()andmerge().Closes #60351.