Skip to content

PERF: indexing on UInt64Index with int64s #41972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2021
Merged

PERF: indexing on UInt64Index with int64s #41972

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
945b5be
PERF: indexing on UInt64Index with int64s
jbrockmendel Jun 12, 2021
7c48fc4
Merge branch 'master' into perf-41873
jbrockmendel Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5303,6 +5303,13 @@ def _maybe_promote(self, other: Index) -> tuple[Index, Index]:
if not is_object_dtype(self.dtype):
return self.astype("object"), other.astype("object")

elif self.dtype.kind == "u" and other.dtype.kind == "i":
# GH#41873
if other.min() >= 0:
# lookup min as it may be cached
# TODO: may need itemsize check if we have non-64-bit Indexes
return self, other.astype(self.dtype)

if not is_object_dtype(self.dtype) and is_object_dtype(other.dtype):
# Reverse op so we dont need to re-implement on the subclasses
other, self = other._maybe_promote(self)
Expand Down