Skip to content

Use take_1d in take_nd #40405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jorisvandenbossche wants to merge 3 commits into from
Closed

Use take_1d in take_nd #40405

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae1f919
Use take_1d in take_nd
jorisvandenbossche Mar 12, 2021
3609eb9
Merge remote-tracking branch 'upstream/master' into take_nd-dispatch-1d
jorisvandenbossche Apr 22, 2021
c5f079d
fixup
jorisvandenbossche Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pandas/core/array_algos/take.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ def take_nd(
if fill_value is lib.no_default:
fill_value = na_value_for_dtype(arr.dtype, compat=False)

if arr.ndim == 1 and axis == 0 and indexer is not None:
indexer = ensure_platform_int(indexer)
Copy link
Member

@jbrockmendel jbrockmendel Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment to the effect of "fastpath"

return take_1d(arr, indexer, allow_fill=allow_fill, fill_value=fill_value)

if not isinstance(arr, np.ndarray):
# i.e. ExtensionArray,
if arr.ndim == 2:
Expand Down