type DatetimeIndex.indexer_at_time and DatetimeIndex.indexer_between_time
#1438
+151
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
datetimeindex-undocumented
branch
from
7312277 to
d40f7e9
Compare
cmp0xff
requested changes
Oct 22, 2025
Comment on lines
31
to
39
| dt_idx = pd.DatetimeIndex(data, name="date") | ||
| check(assert_type(data[x <= dt_idx], pd.DatetimeIndex), pd.DatetimeIndex) | ||
| check(assert_type(data[x >= dt_idx], pd.DatetimeIndex), pd.DatetimeIndex) | ||
| check(assert_type(data[x < dt_idx], pd.DatetimeIndex), pd.DatetimeIndex) | ||
| check(assert_type(data[x > dt_idx], pd.DatetimeIndex), pd.DatetimeIndex) | ||
| check(assert_type(data[dt_idx <= x], pd.DatetimeIndex), pd.DatetimeIndex) | ||
| check(assert_type(data[dt_idx >= x], pd.DatetimeIndex), pd.DatetimeIndex) | ||
| check(assert_type(data[dt_idx < x], pd.DatetimeIndex), pd.DatetimeIndex) | ||
| check(assert_type(data[dt_idx > x], pd.DatetimeIndex), pd.DatetimeIndex) |
There was a problem hiding this comment.
Seems redundant, if my comment above is valid.
There was a problem hiding this comment.
Could you add # TODO: pandas-dev/pandas-stubs#1440 deduplicate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: adds annotations for:
DatetimeIndex.indexer_at_timeDatetimeIndex.indexer_between_timeDatetimeIndex.snapDatetimeIndex.slice_indexer, as it can just inherit fromIndex.slice_indexer(there's no datetime-index-specific docs for this method)DatetimeIndex.__reduce__(not documented)DatetimeIndextests fromtests/indexes/test_indexes.pyto a newtests/indexes/test_datetime_index.pyfileDatetimeIndex.indexer_at_timeandDatetimeIndex.indexer_between_timeto thetest_datetime_indexfile