-
-
Notifications
You must be signed in to change notification settings - Fork 151
Fix: proper return types for MultiIndex.swaplevel & MultiIndex.union #1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
realzachbrownjohn
wants to merge
13
commits into
pandas-dev:main
Choose a base branch
from
realzachbrownjohn:bugfix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−1
Open
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8d51763
Fix: proper return types for MultiIndex.swaplevel & MultiIndex.union
realzachbrownjohn 4552867
Index of and List of tuples in MultiIndex overriding
realzachbrownjohn d3f5757
MultiIndex union tests
realzachbrownjohn d401e0c
MultiIndex-Index union overload simplified
realzachbrownjohn 7739015
MultiIndex test amended and swaplevel test added
realzachbrownjohn 2a77d79
Simplified MultiIndex-Index union overload
realzachbrownjohn 2f5c338
Reverted S1 changes
realzachbrownjohn 5e82ee5
amended MultiIndex union test and added swaplevel test
realzachbrownjohn a606e96
Removed runtime-failing test
realzachbrownjohn 23b603f
Merge branch 'pandas-dev:main' into bugfix
realzachbrownjohn 46e8050
Pre-commit refactoring
realzachbrownjohn 092eec2
Removed a MultiIndex-Index test
realzachbrownjohn 6b676bf
Removed MultiIndex union overloading
realzachbrownjohn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -135,7 +135,7 @@ class MultiIndex(Index): | |
def append(self, other): ... | ||
def repeat(self, repeats, axis=...): ... | ||
def drop(self, codes, level: Level | None = None, errors: str = "raise") -> Self: ... # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride] | ||
def swaplevel(self, i: int = -2, j: int = -1): ... | ||
def swaplevel(self, i: int = -2, j: int = -1) -> Self: ... | ||
cmp0xff marked this conversation as resolved.
Show resolved
Hide resolved
|
||
def reorder_levels(self, order): ... | ||
def sortlevel( | ||
self, | ||
|
@@ -163,3 +163,7 @@ class MultiIndex(Index): | |
def insert(self, loc, item): ... | ||
def delete(self, loc): ... | ||
def isin(self, values, level=...) -> np_1darray[np.bool]: ... | ||
@overload | ||
def union(self, other: Self | list[tuple[Hashable, ...]], sort: bool | None = ...,) -> Self: ... | ||
@overload | ||
def union(self, other: Index | list[HashableT], sort: bool | None = ...,) -> Index: ... | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This extra empty line can also be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you?