Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update router query always when on wallet connect #11174

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Feb 5, 2025


PR-Codex overview

This PR primarily enhances the handling of browser history and wallet connection synchronization in the application. It introduces a new hook for syncing wallet connections and modifies existing components to improve state management and event handling.

Detailed summary

  • Added useWalletConnectRouterSync hook to synchronize wallet connection with the router.
  • Updated replaceBrowserHistory and replaceBrowserHistoryMultiple to dispatch a popstate#pcs event.
  • Integrated useWalletConnectRouterSync in the GlobalHooks component.
  • Refactored currencyBalances in SwapCommitButton.tsx to use useMemo for optimization.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 0:36am
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 0:36am
bridge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 0:36am
games ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 0:36am
gamification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 0:36am
uikit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 0:36am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 0:36am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ton ⬜️ Ignored (Inspect) Feb 6, 2025 0:36am

Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: 96e2b3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chef-ryan chef-ryan merged commit 569025f into develop Feb 10, 2025
20 checks passed
@chef-ryan chef-ryan deleted the feature/fix_update_query_when_wallet_connect branch February 10, 2025 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants