Skip to content

Commit

Permalink
fix(ci): Workflow lint should follow repo config (#8662)
Browse files Browse the repository at this point in the history
  • Loading branch information
0xjojoex authored Dec 25, 2023
1 parent 7bf73e6 commit 054c7fc
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 17 deletions.
14 changes: 1 addition & 13 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,17 +39,5 @@ jobs:
- name: Install dependencies
run: pnpm i --ignore-scripts

- name: Get changed files
id: changed-files
uses: Ana06/[email protected]
with:
format: space-delimited
filter: |
**/*.ts
**/*.tsx
**/*.js
**/*.jsx
token: ${{ secrets.GITHUB_TOKEN }}

- name: Run ESLint
run: pnpm lint:report ${{ steps.changed-files.outputs.added_modified }}
run: pnpm lint:report
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
"start": "turbo run start --filter=web",
"test:config": "pnpm turbo run test:config --filter=web...[HEAD^1]",
"test:ci": "pnpm turbo run test --filter=[HEAD^1]",
"lint": "turbo run lint --filter=web",
"lint:report": "eslint --no-error-on-unmatched-pattern --max-warnings=0",
"lint": "turbo run lint",
"lint:report": "turbo run lint --log-prefix=none",
"format:check": "prettier --check \"**/*.{js,jsx,ts,tsx,json}\"",
"format:write": "prettier --write \"**/*.{js,jsx,ts,tsx,json}\"",
"format:check:staged": "lint-staged",
Expand Down
4 changes: 2 additions & 2 deletions packages/swap-sdk-core/src/errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const CAN_SET_PROTOTYPE = 'setPrototypeOf' in Object
* obtained by sending any amount of input.
*/
export class InsufficientReservesError extends Error {
public readonly isInsufficientReservesError: true = true
public readonly isInsufficientReservesError = true as const

public constructor() {
super()
Expand All @@ -20,7 +20,7 @@ export class InsufficientReservesError extends Error {
* than the price of a single unit of output after fees.
*/
export class InsufficientInputAmountError extends Error {
public readonly isInsufficientInputAmountError: true = true
public readonly isInsufficientInputAmountError = true as const

public constructor() {
super()
Expand Down
1 change: 1 addition & 0 deletions turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"outputs": ["dist/**"]
},
"lint": {
"dependsOn": ["@pancakeswap/next-config#build"],
"outputs": []
},
"dev": {
Expand Down

1 comment on commit 054c7fc

@vercel
Copy link

@vercel vercel bot commented on 054c7fc Dec 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

uikit – ./packages/uikit

uikit.pancake.run
uikit-git-develop.pancake.run

Please sign in to comment.