Security workflow #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have successfully added a new templateanalyzer configuration |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pamelafox
commented
Mar 22, 2023
| @@ -6,7 +6,6 @@ param tags object = {} | |||
| param applicationInsightsName string = '' | |||
| param appServicePlanId string | |||
| param keyVaultName string = '' | |||
| param managedIdentity bool = !empty(keyVaultName) | |||
There was a problem hiding this comment.
Didn't make that change in azure-dev yet, raised a discussion
pamelafox
commented
Mar 22, 2023
| @@ -33,6 +32,7 @@ param numberOfWorkers int = -1 | |||
| param scmDoBuildDuringDeployment bool = false | |||
| param use32BitWorkerProcess bool = false | |||
| param ftpsState string = 'FtpsOnly' | |||
| param healthCheckPath string = '' | |||
There was a problem hiding this comment.
This change is from upstream
pamelafox
commented
Mar 22, 2023
| param containerName string = 'main' | ||
| param containerRegistryName string = '' | ||
| param containerRegistryName string |
pamelafox
commented
Mar 22, 2023
| param logAnalyticsWorkspaceName string = '' | ||
| param containerAppsEnvironmentName string | ||
| param containerRegistryName string | ||
| param logAnalyticsWorkspaceName string |
pamelafox
commented
Mar 22, 2023
| @@ -62,7 +62,6 @@ module functions 'appservice.bicep' = { | |||
| keyVaultName: keyVaultName | |||
| kind: kind | |||
| linuxFxVersion: linuxFxVersion | |||
| managedIdentity: managedIdentity | |||
There was a problem hiding this comment.
Related to my own change to appservice.bicep
pamelafox
commented
Mar 22, 2023
| @@ -1,6 +1,6 @@ | |||
| param name string = 'add' | |||
|
|
|||
| param keyVaultName string = '' | |||
| param keyVaultName string | |||
pamelafox
commented
Mar 22, 2023
| @@ -45,11 +45,13 @@ resource appService 'Microsoft.Web/sites@2022-03-01' = { | |||
| linuxFxVersion: linuxFxVersion | |||
| alwaysOn: alwaysOn | |||
| ftpsState: ftpsState | |||
| minTlsVersion: '1.2' | |||
pamelafox
commented
Mar 22, 2023
| appCommandLine: appCommandLine | ||
| numberOfWorkers: numberOfWorkers != -1 ? numberOfWorkers : null | ||
| minimumElasticInstanceCount: minimumElasticInstanceCount != -1 ? minimumElasticInstanceCount : null | ||
| use32BitWorkerProcess: use32BitWorkerProcess | ||
| functionAppScaleLimit: functionAppScaleLimit != -1 ? functionAppScaleLimit : null | ||
| healthCheckPath: healthCheckPath |
pamelafox
commented
Mar 22, 2023
| @@ -58,7 +60,7 @@ resource appService 'Microsoft.Web/sites@2022-03-01' = { | |||
| httpsOnly: true | |||
| } | |||
|
|
|||
| identity: { type: managedIdentity ? 'SystemAssigned' : 'None' } | |||
| identity: { type: 'SystemAssigned' } | |||
There was a problem hiding this comment.
Undecided managedIdentity change
pamelafox
commented
Mar 22, 2023
| @@ -93,6 +95,6 @@ resource applicationInsights 'Microsoft.Insights/components@2020-02-02' existing | |||
| name: applicationInsightsName | |||
| } | |||
|
|
|||
| output identityPrincipalId string = managedIdentity ? appService.identity.principalId : '' | |||
| output identityPrincipalId string = appService.identity.principalId | |||
There was a problem hiding this comment.
Undecided managedIdentity change
|
Pending suggestions for how to fix functions.bicep: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.