Repository navigation
[rejected AI] Path is generic on path_type - #3834
Closed
dhimasardinata wants to merge 1 commit into
Closed
dhimasardinata wants to merge 1 commit into
dhimasardinata wants to merge 1 commit into
Conversation
Fixes #3822. Parameterize Path with its path_type value so convert, coercion, and prompt() carry the narrowed return type. Runtime unchanged.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3822.
MRE from the issue now passes on mypy, pyright, and ty:
What changed (runtime unchanged, typing only):
Pathis nowParamType[_PathValueT_co], Generic[_PathValueT_co]with a PEP 696 default (str | bytes | os.PathLike[str]), matching the existingParamTypesecond-param pattern for py3.10 compat.__init__overloads inferPath[T]frompath_type: type[T]; barePath()keeps the default union.convert/coerce_path_resultreturn the generic value type;self.typeannotated asbuiltins.type[...] | None(avoids shadowing thetypeattribute).tests/typing/typing_path.pyassert_type coverage and CHANGES entry.Verified:
mypyclean (29 files, strict)pyright --ignoreexternal --verifytypes click100% + 0 errors on new typing test and issue MREruff check+ruff format --checkcleanpytest tests/test_types.py45 passed; manual runtime smoke (str/bytes/pathlib converts,Path[pathlib.Path]alias) unchanged.