-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix test_edit to work with BSD sed #3129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please add a comment. |
@Rowlando13 could you please elaborate what kind of comment you mean? Thank you. |
|
Explain in short why the test was altered. Specifically note the os and reason. If you don't we may unintentionally break the test again or add a similar breaking test. |
Here in the PR, or in the sources? |
|
If by sources you mean in tests/test_termui.py, then yes. |
Okay, will do. In the meantime, POSIX says this about sed: So it looks like GNU sed does not follow this accurately. |
Done. @Rowlando13 please let me know if you'd prefer different wording there. Thank you. |
Fixes #3128.