Fix: Bleeding Sentinel.UNSET to upstream users #3073
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since release 8.3.0, the Sentinel.UNSET enum value has been bleeding to users of click where options have no default and the value is not required. This commit contains a test which failed demonstrating the bleeding UNSET value and the fix in src/click/core.py to return to the previous behavior of returning None.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since release
v8.3.0, theSentinel.UNSETenum value has been bleeding to users of click where options have no default and the value is not required.This commit contains a test which failed demonstrating the bleeding
UNSETvalue and the fix insrc/click/core.pyto return to the previous behavior of returningNone.Issues mentioning this bug
fixes #3065
fixes #3066
fixes #3069
Moving forward
I'd like feedback on this.
CHANGES.rst? I've made a pass, but I cannot guarantee its correct.