Replace Glyphicons with Bootstrap icons #2690
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samialfattani
changed the title
Contributor
Author
|
what do we need to merge this PR? |
Contributor
|
This changes doesn't seem like a backwards-compatible one (somewhat at my request, but this initially came in at an awkward time near the v2 release so I was hoping it might get in for that, but didn't). Someone in pallets-eco probably needs to take the time to understand the problem and back up the approach here, and then work out what kind of release we schedule this for (v2.0.2 / v2.1 / v3). I haven't had time to do that yet I'm afraid; very happy for anyone else to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Glyphicons shows unstable behavior in most cases of the whole project where sometimes icons are just no longer visible. To the best of my knowleadge, glyphicon is not for free any more except for a very limited package. Thus, here in this PR, i'm suggesting to use Bootstrap Icons where it is totally free and compatible with Bootstrap theme.
This PR fixes all disappeared icons that are written with glyphicon and they are replaced with Bootstrap ones. Moreover, Glyph icons is completely removed from the project.
/examples/bootstrap4showing variety of bootstrap usage.Note: In some parts of the code, glyphicon is already prefixed with Fontawesome icons css classes, so that the icon can be visible properly. I never change those cases since the icon is looking just fine. However I suggest to deprecate Glyphicon at all and keep Fontawesome and Bootstrap