Provide bang versions of meta methods #261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202
What is the purpose of this pull request?
Provide
Logidze.with_meta!andLogidize.with_responsible!to attach these details permanently instead of for the duration of a block. This resolves #202 and allows the behavior outlined in #200:It also considers feedback in the attempt from #203.
Finally, this resolves #221, although using this in web requests comes with its own risks.
What changes did you make? (overview)
In
Logidze::MetaMetaBasepulling meta stack management fromMetaWrapperMetaForConnectionto manage metadata for bang methods.with_meta!to set metadata with no implicit end.with_responsible!to set actor id with no implicit end.clear_meta!to explicitly clear metadataIs there anything you'd like reviewers to focus on?
I'm not sure how I feel about this implementation so I'm happy to revisit it if there are suggestions. I believe i hit the use-cases missed in #203.
Changelog/Readme changes will be added after the approach has been established.
Checklist