Skip to content

Conversation

@yoelbassin
Copy link

@yoelbassin yoelbassin commented Feb 19, 2023

Closed #164 since the source branch have changed.
Here is the PR rebased from react-v18

@palerdot
Copy link
Owner

Thanks, I'm tracking this PR in this issue - #166

@palerdot palerdot changed the base branch from react-v18 to master February 23, 2023 10:13
@palerdot
Copy link
Owner

@yoelbassin This PR introduces a new prop valueTextBelowPos without being discussed. It would be better if this prop is discussed before making code changes. I'm not also not ok with the prop name valueTextBelowPos, which does not clearly indicate what this does exactly.

There is a whole lot to be done including updating documentation when a new prop is introduced - #153

This prop change should be discussed including the name in the issue - #166, before I can consider on next steps regarding this PR.

@palerdot palerdot changed the title fix fluid width to fill only needed space Fluid Width prop to take only available space Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants