Avoid POSIX permission changes on non-POSIX filesystems#658
Open
farouk-01 wants to merge 4 commits intopalantir:developfrom
Open
Avoid POSIX permission changes on non-POSIX filesystems#658farouk-01 wants to merge 4 commits intopalantir:developfrom
farouk-01 wants to merge 4 commits intopalantir:developfrom
Conversation
Member
|
Thanks for your interest in palantir/gradle-jdks, @farouk-01! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Generate changelog in
|
farouk-01
force-pushed
the
fix/windows-posix-permissions
branch
from
4eb6418 to
47a2b90
Compare
… non-POSIX filesystems
Author
|
changelog: fix |
farouk-01
force-pushed
the
fix/windows-posix-permissions
branch
from
b41d93d to
988c4a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
On non-POSIX filesystems (e.g., Windows/NTFS), calling Files.setPosixFilePermissions throws UnsupportedOperationException, which can crash workflows that attempt to set execute permissions.
After this PR
==COMMIT_MSG==
Avoid UnsupportedOperationException when setting POSIX permissions on non-POSIX filesystems
==COMMIT_MSG==
Guard POSIX permission updates behind a filesystem capability check. On non-POSIX
filesystems the operation is skipped and on POSIX filesystems behavior is unchanged.
Possible downsides?
None.