-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix Hotkeys for custom keyboard layouts #7659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from 5 commits
ea382d3
066c216
5b10084
986d476
da01f28
49e1bde
4cbef11
076ffe7
9842ca0
0c2df74
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,6 +60,30 @@ export class HotkeysTargetExample extends PureComponent<ExampleProps, HotkeysTar | |
| label: "Focus the piano", | ||
| onKeyDown: this.focusPiano, | ||
| }, | ||
| { | ||
| combo: "ctrl + B", | ||
| group: "Modifier Tests", | ||
| label: "Test Ctrl+B", | ||
| onKeyDown: () => console.log("Ctrl+B pressed"), | ||
|
||
| }, | ||
| { | ||
| combo: "alt + B", | ||
| group: "Modifier Tests", | ||
| label: "Test Alt+B", | ||
| onKeyDown: () => console.log("Alt+B pressed"), | ||
| }, | ||
| { | ||
| combo: "shift + B", | ||
| group: "Modifier Tests", | ||
| label: "Test Shift+B", | ||
| onKeyDown: () => console.log("Shift+B pressed"), | ||
| }, | ||
| { | ||
| combo: "meta + B", | ||
| group: "Modifier Tests", | ||
| label: "Test Cmd/Meta+B", | ||
| onKeyDown: () => console.log("Meta+B pressed"), | ||
| }, | ||
| { | ||
| combo: "Q", | ||
| group: "HotkeysTarget Example", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Do you have additional tests in mind for having an alternate layout and checking keys?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some extra tests