Keep disabling warning 4189 as d3d10sw still fails to build otherwise

Revert 78ba584
pal1000 · Feb 24, 2023 · 1a7aa34 · 1a7aa34
1 parent 5c26ae7
commit 1a7aa34
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/buildscript/modules/mesa3d.cmd b/buildscript/modules/mesa3d.cmd
@@ -205,7 +205,7 @@
 @echo.
 @if /I "%mesaenableasserts%"=="y" set buildconf=%buildconf% -Db_ndebug=false
 @if /I NOT "%mesaenableasserts%"=="y" set buildconf=%buildconf% -Db_ndebug=true
-@if /I NOT "%mesaenableasserts%"=="y" IF %toolchain%==msvc IF %intmesaver:~0,3% EQU 230 IF %intmesaver% LSS 23005 set CFLAGS=/wd4189
+@if /I NOT "%mesaenableasserts%"=="y" IF %toolchain%==msvc set CFLAGS=/wd4189
 
 @set linkmingwdynamic=n
 @IF NOT %toolchain%==msvc set /p linkmingwdynamic=Link dependencies dynamically for debuggging purposes (y/n):

diff --git a/releasenotes.md b/releasenotes.md
@@ -1,7 +1,8 @@
 ### Sponsorship
 - Upate affiliate link.
 ### Build script
-- Move question about futex usage before unit tests build one to reflect [user feedback](https://github.com/pal1000/mesa-dist-win/discussions) trend.
+- Move question about futex usage before unit tests build one to reflect [user feedback](https://github.com/pal1000/mesa-dist-win/discussions) trend;
+- Keep disabling warning 4189 as d3d10sw still fails to build otherwise, revert 78ba58430edbd06b6233b37756af3fde608530ce.
 ### Out of tree patches
 - ARM64: Update MCJIT patch to final form and stop applying it to 23.1;
 - OpenCL SPIRV: Add patch fixing CLC JIT compilation with LLVM and clang 15 [22.3/23.0 up to 23.0.0].