CK app #23
Open
CK app #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
jaybobo
reviewed
Dec 12, 2017
Member
jaybobo
left a comment
jaybobo
left a comment
There was a problem hiding this comment.
Looks good. There are a couple of rails specific things I noticed. I left your JS alone :P
FYI, this is a thing: http://edgeguides.rubyonrails.org/api_app.html
| end | ||
|
|
||
| def show | ||
| @task = Task.find(params[:id]) |
Member
There was a problem hiding this comment.
looks good. we might clean up lines 9, 23 & 33 with a before_action.
see: http://api.rubyonrails.org/classes/AbstractController/Callbacks/ClassMethods.html
|
|
||
| def create | ||
| @task = Task.new(task_params) | ||
| if @task.valid? |
Member
There was a problem hiding this comment.
.save! will run validations in this case. you can save yourself a line here.
See: http://api.rubyonrails.org/classes/ActiveRecord/Persistence.html#method-i-save-21
|
|
||
| def update | ||
| @task = Task.find(params[:id]) | ||
| @task.update(task_params) |
Member
There was a problem hiding this comment.
.update! calls .save!
See: See: http://api.rubyonrails.org/classes/ActiveRecord/Persistence.html#method-i-save-21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.