Skip to content

rmaiya_solution-Parser1 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajashreemaiya wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rmaiya_solution-Parser1 #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
def word_in_string?(word, string)
# implement with your code here
string = string.gsub(/_|-/," ")
/^(.*(\b#{word}\b).*)$/.match("#{string}")? :yes : :no
Copy link

@sampriddy sampriddy Jan 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a little curious to try to match on the entire string. You could get away with a way more simple regex, especially since you're sanitizing the input string on line 2. Check out Rubular and you might be surprised how small you can make that matcher.

end