initial commit #46
initial commit #46
Conversation
|
I think this could be a bit more "object oriented". Consider the initializer taking the filename, preprocessing it to some degree, and a getter method to finish the work and retrieve the data you want. |
|
|
||
| # count all the words and add them to a hash | ||
| def countAllWords(cleanedText) | ||
| wordCount = {} |
There was a problem hiding this comment.
anytime you initialize a collection to then iteratively build it up is a clue to maybe use a method like .map or .reduce which are common in a lot of languages.
here i'd recommend using a method like .reduce or .each_with_object.
lines 37-46 could also be written:
cleaned_text.reduce(Hash.new(0)) { |hash,word| hash[word] += 1; hash }or
cleaned_text.each_with_object(Hash.new(0)) { |word, hash| hash[word] += 1}| # parse text | ||
| def run(filename) | ||
|
|
||
| # read the text file |
There was a problem hiding this comment.
i like the pipelining. Also see Mike Gee's comment on sticking some of this stuff into the constructor.
| require 'count_words' | ||
|
|
||
| describe CountWords do | ||
| it 'should be a Class' do |
| end | ||
|
|
||
| it 'should read a file that exists' do | ||
| countWords = CountWords.new |
There was a problem hiding this comment.
See betterspecs.org documentation on let
http://www.betterspecs.org/
3 participants
@jaybobo
@mikegee