Andrew Petit Solution #44
Conversation
| @@ -0,0 +1,31 @@ | |||
|
|
|||
| def readFile(file) | |||
| return File.read(file) | |||
There was a problem hiding this comment.
No need for an explicit return here.
With regards to method names, lower snakecase is generally the rule.
https://github.com/bbatsov/ruby-style-guide
|
|
||
|
|
||
| def getWords(text) | ||
| text.gsub!(/[^A-Za-z ]/,'') |
There was a problem hiding this comment.
.gsub! mutates your data. how about using i.gsub and returning a modified copy instead?
|
|
||
| def getWords(text) | ||
| text.gsub!(/[^A-Za-z ]/,'') | ||
| data = Hash.new |
There was a problem hiding this comment.
Anytime you initialize a new object and then build it up is a good time to ask could I use .reduce or .map.
In this case, there's an even better option .each_with_object. Try refactoring and using it instead.
https://ruby-doc.org/core-2.4.1/Enumerable.html#method-i-each_with_object
| text.gsub!(/[^A-Za-z ]/,'') | ||
| data = Hash.new | ||
| temparray = text.to_s.split(" ").map(&:to_s) | ||
| for word in temparray |
There was a problem hiding this comment.
You won't see a lot of "for loops" used in ruby. There's usually a better option available if you sniff around in...
https://ruby-doc.org/core-2.4.1/Enumerable.html
https://ruby-doc.org/core-2.4.1/Array.html
https://ruby-doc.org/core-2.4.1/Hash.html
https://ruby-doc.org/core-2.4.1/Times.html
| require_relative '../lib/readfile.rb' | ||
|
|
||
| describe 'Number of words' do | ||
| it 'get words return the proper number' do |
There was a problem hiding this comment.
2 spaces. https://github.com/bbatsov/ruby-style-guide
Check out this great site on rspec best practices.
www.betterspecs.org
2 participants
@jaybobo