Skip to content

Justin holm #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jlholm wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Justin holm #38

jlholm wants to merge 2 commits into from

Conversation

@jlholm
Copy link

@jlholm jlholm commented May 15, 2017 •
edited
Loading

mikegee
mikegee reviewed May 30, 2017
View reviewed changes
count.rb
end
end

Counter.new
Copy link
Member

@mikegee mikegee May 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unusual to do all the work in initialize; I would expect Counter.new to prepare a counter object ready to do the work.

It is a bit arbitrary which parts of the code are setup and which are the real work. Perhaps reading the file still belongs in initialize. I like to do some of the prep work in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikegee mikegee mikegee left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jlholm @mikegee