-
Notifications
You must be signed in to change notification settings - Fork 36
completed onboarding #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lmieu
wants to merge
2
commits into
paircolumbus:master
Choose a base branch
from
lmieu:musielh
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| def shred line #split lines into words | ||
| line.split /[\?\.,_:;@#\n\$\^\*\<\>\%\&!{}\+\n\\"\)\(\-— ]+/ | ||
| #personalize regex for 'word' definition | ||
| end | ||
|
|
||
| def add_to_list array_of_words, list #adds only new words to hash list | ||
| array_of_words.each do |word| | ||
| key = word.upcase.capitalize #downcase to prevent case mattering | ||
| if list.has_key? key #if word already exists, inc count | ||
| list["#{key}"]=list["#{key}"]+1 | ||
| else #else create new hash key and value | ||
| list["#{key}"] = 1 | ||
| end | ||
| end | ||
| end | ||
|
|
||
| #reads file in and returns array for printing | ||
| def generate_list filename | ||
| input = File.new filename, "r+" #opens file for reading | ||
| list = Hash.new #creates hash for wordcount list | ||
|
||
| shredded = Array.new #temporary storage for lines | ||
| input.each_line do |line| | ||
| shredded = shred line #break lines into words | ||
| add_to_list shredded, list #adds words to hash of word, value pairs | ||
| end | ||
| array=list.to_a | ||
| array.sort!{|a,b| b[1]<=>a[1]} #sort by count | ||
| end | ||
|
|
||
| def print_list filename | ||
| list = generate_list filename | ||
| puts "#{list.count} words in list" | ||
| list.each do |pair| #prints | ||
| puts "#{pair[1]} — #{pair[0]}" | ||
| end | ||
| end | ||
|
|
||
| print_list "speech.txt" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
keyis a string, there's no need to interpolate it into a new string."#{key}"is better written askey.When you want to increment a value in Ruby, the typical syntax is:
foo += 1.Together:
list[key] += 1